test: Added ability to switch the transport to UTP from the command line#1991
Merged
test: Added ability to switch the transport to UTP from the command line#1991
Conversation
… allow for setting the transport to UTP
SamuelBellomo
approved these changes
Jun 1, 2022
|
|
||
| // Configuration via configuration file - all platform support but set at build time | ||
| if (ConfigurationType == ConfigurationType.Unknown) | ||
| { |
Member
There was a problem hiding this comment.
Shouldn't we add some form of debug log or warning that notifies the configuration type is unknown?
Contributor
Author
There was a problem hiding this comment.
Oh yeah, that's right. Previously if things weren't set up correctly we'd assert and fail the test but this looks like it'll continue on with no indication of what went wrong.
I'll make an appropriate message and submit an update shortly.
NoelStephensUnity
approved these changes
Jun 1, 2022
Member
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Other than my minor comment about adding some form of debug output when the configuration is unknown (was not sure when the next PR will be), the rest looks good to me!
ashwinimurt
reviewed
Jun 3, 2022
0xFA11
approved these changes
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to switch the transport to UTP from the command line and also ensuring consistent handling of other command line arguments like "-ip" and "-p" for setting the server listen address or the client connect address.
More work to follow for other configuration types, mainly remote config via http.